[vbox-dev] Faulty logging code

[Ray Yang]

The following logging code is missing the last parameter for uTagSrc:


static int apic_deliver(APICDeviceInfo *pDev, APICState *pApic,
uint8_t dest, uint8_t dest_mode,
uint8_t delivery_mode, uint8_t vector_num,
uint8_t polarity, uint8_t trigger_mode)
{
int dest_shorthand = (pApic->icr[0] >> 18) & 3;
LogFlow(("apic_deliver dest=%x dest_mode=%x dest_shorthand=%x
delivery_mode=%x vector_num=%x polarity=%x trigger_mode=%x
uTagSrc=%#x\n", dest, dest_mode, dest_shorthand, delivery_mode,
vector_num, polarity, trigger_mode));

So it results the following log message:

apic_deliver dest=1 dest_mode=0 dest_shorthand=0 delivery_mode=5
vector_num=0 polarity=1 trigger_mode=1 uTagSrc=0xcccccccc

[Frank Mehnert]

Hi Ray,

Post by Ray Yang
static int apic_deliver(APICDeviceInfo *pDev, APICState *pApic,
uint8_t dest, uint8_t dest_mode,
uint8_t delivery_mode, uint8_t vector_num,
uint8_t polarity, uint8_t trigger_mode)
{
int dest_shorthand = (pApic->icr[0] >> 18) & 3;
LogFlow(("apic_deliver dest=%x dest_mode=%x dest_shorthand=%x
delivery_mode=%x vector_num=%x polarity=%x trigger_mode=%x
uTagSrc=%#x\n", dest, dest_mode, dest_shorthand, delivery_mode,
vector_num, polarity, trigger_mode));
apic_deliver dest=1 dest_mode=0 dest_shorthand=0 delivery_mode=5
vector_num=0 polarity=1 trigger_mode=1 uTagSrc=0xcccccccc

thanks for the report, fixed in current trunk.

Frank
--
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weinstadt, Germany

Hauptverwaltung: Riesstr. 25, D-80992 M?nchen
Registergericht: Amtsgericht M?nchen, HRA 95603
Gesch?ftsf?hrer: J?rgen Kunz

Komplement?rin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher