[vbox-dev] <PATCH> Minor changes to e1000 device to support Phar Lap ETS

Discussion:

Jeff Westfahl

2014-04-06 02:53:28 UTC

Here's a patch to the e1000 emulated device that allows it to work with
drivers we've written for Phar Lap ETS, an RTOS we use on some of our
products. Please consider this for inclusion in VirtualBox. I won't claim
to have done exhaustive regression testing, but the e1000 driver for a
Windows 7 64-bit VM seems to run just fine with this patch applied. The
patch is against 4.3.8 OSE, but applied cleanly to public SVN.

Author: Jeff Westfahl <jeff.westfahl at ni.com>
License: Patch is under MIT license

Regards,

Jeff Westfahl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: e1000patch.diff
Type: text/x-diff
Size: 1541 bytes
Desc:
Url : http://www.virtualbox.org/pipermail/vbox-dev/attachments/20140405/705f0c19/attachment.bin

Aleksey Ilyushin

2014-04-07 19:11:43 UTC

Permalink

Jeff,

Are you sure there is no need to set MDIC.E bit to indicate an error when the driver attempts to read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely sets MDIC.R as if the operation was successful.

Regards,
Aleksey

Here's a patch to the e1000 emulated device that allows it to work with drivers we've written for Phar Lap ETS, an RTOS we use on some of our products. Please consider this for inclusion in VirtualBox. I won't claim to have done exhaustive regression testing, but the e1000 driver for a Windows 7 64-bit VM seems to run just fine with this patch applied. The patch is against 4.3.8 OSE, but applied cleanly to public SVN.
Author: Jeff Westfahl <jeff.westfahl at ni.com>
License: Patch is under MIT license
Regards,
Jeff Westfahl<e1000patch.diff>_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Jeff Westfahl

2014-04-07 19:43:34 UTC

Permalink

Aleksey,

Yes, setting MDIC_ERROR in addition to MDIC_READY is probably better
behavior. I tested our drivers and they continue to work with both of
these bits set, so no complaints about that here.

Would you like me to resubmit the patch with this change?

Regards,

Jeff Westfahl

Aleksey Ilyushin <aleksey.ilyushin at oracle.com> wrote on 04/07/2014

From: Aleksey Ilyushin <aleksey.ilyushin at oracle.com>
To: vbox-dev at virtualbox.org,
Date: 04/07/2014 02:13 PM
Subject: Re: [vbox-dev] <PATCH> Minor changes to e1000 device to support

Phar Lap ETS

Jeff,
Are you sure there is no need to set MDIC.E bit to indicate an error

when the driver attempts to

read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely

sets MDIC.R as if the

operation was successful.
Regards,
Aleksey

Post by Jeff Westfahl
Here's a patch to the e1000 emulated device that allows it to work

with drivers we've written

for Phar Lap ETS, an RTOS we use on some of our products. Please

consider this for inclusion in

VirtualBox. I won't claim to have done exhaustive regression testing,

but the e1000 driver for a

Windows 7 64-bit VM seems to run just fine with this patch applied. The

patch is against 4.3.8

OSE, but applied cleanly to public SVN.

Post by Jeff Westfahl
Author: Jeff Westfahl <jeff.westfahl at ni.com>
License: Patch is under MIT license
Regards,
Jeff

Westfahl<e1000patch.diff>_______________________________________________

Post by Jeff Westfahl
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Aleksey Ilyushin

2014-04-09 13:21:06 UTC

Permalink

Jeff,

No, there is no need. I?ll add MDIC_ERROR to the patch and will apply it.

Many thanks for the patch!

Regards,
Aleksey

Post by Jeff Westfahl
Aleksey,
Yes, setting MDIC_ERROR in addition to MDIC_READY is probably better
behavior. I tested our drivers and they continue to work with both of
these bits set, so no complaints about that here.
Would you like me to resubmit the patch with this change?
Regards,
Jeff Westfahl
Aleksey Ilyushin <aleksey.ilyushin at oracle.com> wrote on 04/07/2014

From: Aleksey Ilyushin <aleksey.ilyushin at oracle.com>
To: vbox-dev at virtualbox.org,
Date: 04/07/2014 02:13 PM
Subject: Re: [vbox-dev] <PATCH> Minor changes to e1000 device to support

Phar Lap ETS

Jeff,
Are you sure there is no need to set MDIC.E bit to indicate an error

when the driver attempts to

read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely

sets MDIC.R as if the

operation was successful.
Regards,
Aleksey

Post by Jeff Westfahl
Here's a patch to the e1000 emulated device that allows it to work

with drivers we've written

for Phar Lap ETS, an RTOS we use on some of our products. Please

consider this for inclusion in

VirtualBox. I won't claim to have done exhaustive regression testing,

but the e1000 driver for a

Windows 7 64-bit VM seems to run just fine with this patch applied. The

patch is against 4.3.8

OSE, but applied cleanly to public SVN.

Post by Jeff Westfahl
Author: Jeff Westfahl <jeff.westfahl at ni.com>
License: Patch is under MIT license
Regards,
Jeff

Westfahl<e1000patch.diff>_______________________________________________

Post by Jeff Westfahl
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Jeff Westfahl

2014-04-10 01:21:01 UTC

Permalink

Aleksey,

Unfortunately I found a problem with the WriteRDT part of my patch.
Further testing with ETS showed that it didn't cover all cases. Here's an
updated patch that fixes the WriteRDT problem with my previous patch, and
also sets MDIC_ERROR as previously discussed.

Regards,

Jeff Westfahl

Post by Aleksey Ilyushin
Jeff,
No, there is no need. I?ll add MDIC_ERROR to the patch and will apply it.
Many thanks for the patch!
Regards,
Aleksey

From: Aleksey Ilyushin <aleksey.ilyushin at oracle.com>
To: vbox-dev at virtualbox.org,
Date: 04/07/2014 02:13 PM
Subject: Re: [vbox-dev] <PATCH> Minor changes to e1000 device to support

Phar Lap ETS

Jeff,
Are you sure there is no need to set MDIC.E bit to indicate an error

when the driver attempts to

read/write from non-existing (MDIC.PHYADD != 1) PHY? Your patch merely

sets MDIC.R as if the

operation was successful.
Regards,
Aleksey

Post by Jeff Westfahl
Here's a patch to the e1000 emulated device that allows it to work

with drivers we've written

for Phar Lap ETS, an RTOS we use on some of our products. Please

consider this for inclusion in

VirtualBox. I won't claim to have done exhaustive regression testing,

but the e1000 driver for a

Windows 7 64-bit VM seems to run just fine with this patch applied. The

patch is against 4.3.8

OSE, but applied cleanly to public SVN.

Post by Jeff Westfahl
Author: Jeff Westfahl <jeff.westfahl at ni.com>
License: Patch is under MIT license
Regards,
Jeff

Westfahl<e1000patch.diff>_______________________________________________

Post by Jeff Westfahl
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: e1kpatch.diff
Type: text/x-diff
Size: 1607 bytes
Desc:
Url : http://www.virtualbox.org/pipermail/vbox-dev/attachments/20140409/a507a968/attachment.bin

Jeff Westfahl

2014-04-21 14:15:27 UTC

Permalink

Aleksey,

Just wanted to check on the status of this patch. I haven't heard from
you since I updated it, and I haven't seen it go into SVN.

Regards,

Jeff Westfahl

From: Jeff Westfahl <jeff.westfahl at ni.com>
To: Aleksey Ilyushin <aleksey.ilyushin at oracle.com>,
Cc: vbox-dev at virtualbox.org
Date: 04/09/2014 08:22 PM
Subject: Re: [vbox-dev] <PATCH> Minor changes to e1000 device to support

Phar Lap ETS

Aleksey,
Unfortunately I found a problem with the WriteRDT part of my patch.
Further testing with ETS showed that it didn't cover all cases. Here's an
updated patch that fixes the WriteRDT problem with my previous patch, and
also sets MDIC_ERROR as previously discussed.
Regards,
Jeff Westfahl

Aleksey Ilyushin

2014-04-28 08:52:49 UTC

Permalink

Jeff,

I?ve integrated the updated version into the trunk and tested it for regressions with several guests. You should be able to see the changes soon.

Regards,
Aleksey

Post by Jeff Westfahl
Aleksey,
Just wanted to check on the status of this patch. I haven't heard from
you since I updated it, and I haven't seen it go into SVN.
Regards,
Jeff Westfahl

Phar Lap ETS

Aleksey,
Unfortunately I found a problem with the WriteRDT part of my patch.
Further testing with ETS showed that it didn't cover all cases. Here's

updated patch that fixes the WriteRDT problem with my previous patch,

and

also sets MDIC_ERROR as previously discussed.
Regards,
Jeff Westfahl

Frank Mehnert

2014-04-28 11:18:40 UTC

Permalink

Hi,

please note that we do not intend to backport this patch to VBox 4.3.x for
stability reasons, that is, even when we tested the patch with several
guests there is still a slight chance that it breaks certain guests.
Therefore the patch will be part of the next major release.

Thanks,

Frank

Post by Aleksey Ilyushin
Jeff,
I?ve integrated the updated version into the trunk and tested it for
regressions with several guests. You should be able to see the changes
soon.
Regards,
Aleksey

Post by Jeff Westfahl
Aleksey,
Just wanted to check on the status of this patch. I haven't heard from
you since I updated it, and I haven't seen it go into SVN.
Regards,
Jeff Westfahl

Phar Lap ETS

Aleksey,
Unfortunately I found a problem with the WriteRDT part of my patch.
Further testing with ETS showed that it didn't cover all cases. Here's

updated patch that fixes the WriteRDT problem with my previous patch,

and

also sets MDIC_ERROR as previously discussed.
Regards,
Jeff Westfahl

_______________________________________________
vbox-dev mailing list
vbox-dev at virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

--
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384 Weinstadt, Germany

Hauptverwaltung: Riesstr. 25, D-80992 M?nchen
Registergericht: Amtsgericht M?nchen, HRA 95603
Gesch?ftsf?hrer: J?rgen Kunz

Komplement?rin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://www.virtualbox.org/pipermail/vbox-dev/attachments/20140428/8f857478/attachment-0001.bin